Skip to contentSkip to conversation

Change in openvpn[master]: dns: minimalist fix for dnssec setting

Openvpn-devel In review selvanair (Code Review) 2 participants 6 messages Apr 29 – Apr 30 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1777503561000.I0cb093e0116e92d874162d51be777aa43674c115@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email

to review the following change.

Change subject: dns: minimalist fix for dnssec setting
......................................................................

dns: minimalist fix for dnssec setting

Github: fixes OpenVPN/openvpn#1024

Change-Id: I0cb093e0116e92d874162d51be777aa43674c115
---
M src/openvpn/dns.c

1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/44/1644/1

src/openvpn/dns.c +1 -1
index ce23f1f..954ed52 100644
@@ -442,7 +442,7 @@
         .header = { (add ? msg_add_nrpt_cfg : msg_del_nrpt_cfg), sizeof(nrpt_dns_cfg_message_t),
                     0 },
         .iface = { .index = tt->adapter_index, .name = "" },
-        .flags = server->dnssec == DNS_SECURITY_NO ? 0 : nrpt_dnssec,
+        .flags = server->dnssec == DNS_SECURITY_YES ? nrpt_dnssec : 0,
     };
     strncpynt(nrpt.iface.name, tt->actual_name, sizeof(nrpt.iface.name));
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0cb093e0116e92d874162d51be777aa43674c115
Gerrit-Change-Number: 1644
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: plaisthos, selvanair.

flichtenheld has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email )

Change subject: dns: minimalist fix for dnssec setting
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0cb093e0116e92d874162d51be777aa43674c115
Gerrit-Change-Number: 1644
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: selvanair <[email protected]...>
Gerrit-Comment-Date: Thu, 30 Apr 2026 10:07:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

#3 lore raw

PATCH 1/1 dns: minimalist fix for dnssec setting

In reply to a message not in the archive

From: Selva Nair <[email protected]...>

Github: fixes OpenVPN/openvpn#1024

Change-Id I0cb093e0116e92d874162d51be777aa43674c115

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1644
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1644
This mail reflects revision 1 of this Change.

Signed-off-by line for the author was added as per our policy.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <[email protected]...>

src/openvpn/dns.c +1 -1
index ce23f1f..954ed52 100644
@@ -442,7 +442,7 @@
         .header = { (add ? msg_add_nrpt_cfg : msg_del_nrpt_cfg), sizeof(nrpt_dns_cfg_message_t),
                     0 },
         .iface = { .index = tt->adapter_index, .name = "" },
-        .flags = server->dnssec == DNS_SECURITY_NO ? 0 : nrpt_dnssec,
+        .flags = server->dnssec == DNS_SECURITY_YES ? nrpt_dnssec : 0,
     };
     strncpynt(nrpt.iface.name, tt->actual_name, sizeof(nrpt.iface.name));
 
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: dns: minimalist fix for dnssec setting

Thanks for coming up with a minimal patch quickly, until we have decided what "we really want there" and "what windows does".

Frank has tested this, and I have fixed my testbed to actually *show* the problem - we do windows tests, but the way I had set up the "hidden DNS things that only resolve if --dns is applied correctly" (unbound with a local zone) was IPSEC-agnostic - if you ask "the authoritative server" it will always tell you "yeah, all is valid!". So now we have an unbound recursor in front of a local bind, with no DNSSEC, and "windows with dnssec yes" will actually fail to resolve that...

.. and with your patch, we're back to "the system tests pass", so, good.

(Staring at the change also seems to make sense, but I said so for the other fix as well... so I'm glad we have good before/after tests this time)

Your patch has been applied to the master and release/2.7 branch.

commit 919f5ced7d2863d51981979a336407b6e0818fcd (master) commit 9683e1fe273db94ab92e1da2fe55c7929fa7291a (release/2.7)

Author: Selva Nair
Date:   Thu Apr 30 14:40:14 2026 +0200
     dns: minimalist fix for dnssec setting

     Signed-off-by: Selva Nair <[email protected]...>
     Acked-by: Frank Lichtenheld <[email protected]...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1644
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg36797.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld

Change subject: dns: minimalist fix for dnssec setting
......................................................................

dns: minimalist fix for dnssec setting

Github: fixes OpenVPN/openvpn#1024

Change-Id I0cb093e0116e92d874162d51be777aa43674c115

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1644
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36797.html

---
M src/openvpn/dns.c

1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/44/1644/2

src/openvpn/dns.c +1 -1
index ce23f1f..954ed52 100644
@@ -442,7 +442,7 @@
         .header = { (add ? msg_add_nrpt_cfg : msg_del_nrpt_cfg), sizeof(nrpt_dns_cfg_message_t),
                     0 },
         .iface = { .index = tt->adapter_index, .name = "" },
-        .flags = server->dnssec == DNS_SECURITY_NO ? 0 : nrpt_dnssec,
+        .flags = server->dnssec == DNS_SECURITY_YES ? nrpt_dnssec : 0,
     };
     strncpynt(nrpt.iface.name, tt->actual_name, sizeof(nrpt.iface.name));
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0cb093e0116e92d874162d51be777aa43674c115
Gerrit-Change-Number: 1644
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email )

Change subject: dns: minimalist fix for dnssec setting
......................................................................

dns: minimalist fix for dnssec setting

Github: fixes OpenVPN/openvpn#1024

Change-Id I0cb093e0116e92d874162d51be777aa43674c115

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1644
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36797.html

---
M src/openvpn/dns.c

1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/dns.c +1 -1
index ce23f1f..954ed52 100644
@@ -442,7 +442,7 @@
         .header = { (add ? msg_add_nrpt_cfg : msg_del_nrpt_cfg), sizeof(nrpt_dns_cfg_message_t),
                     0 },
         .iface = { .index = tt->adapter_index, .name = "" },
-        .flags = server->dnssec == DNS_SECURITY_NO ? 0 : nrpt_dnssec,
+        .flags = server->dnssec == DNS_SECURITY_YES ? nrpt_dnssec : 0,
     };
     strncpynt(nrpt.iface.name, tt->actual_name, sizeof(nrpt.iface.name));
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1644?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0cb093e0116e92d874162d51be777aa43674c115
Gerrit-Change-Number: 1644
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>